microdadosBrasil icon indicating copy to clipboard operation
microdadosBrasil copied to clipboard

Updates in metadata/dictionaries

Open nicolassoarespinto opened this issue 7 years ago • 3 comments

@lucasmation I think will be easier to keep track of the update status of each dataset if we start to reference all commits of that kind ( no code change involved, only changes in dictionaries/tables) to the same issue.

nicolassoarespinto avatar Oct 25 '17 14:10 nicolassoarespinto

Shouldn't this be done by adding a tag?

If we use issues, shouldn't they be dataset specific ?

Em 25 de out de 2017 12:07 PM, "nicolassoarespinto" < [email protected]> escreveu:

@lucasmation https://github.com/lucasmation I think will be easier to keep track of the update status of each dataset if we start to reference all commits of that kind ( no code change involved, only changes in dictionaries/tables) to the same issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lucasmation/microdadosBrasil/issues/152, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXDiIT7qsjJ-36flGyUlw81a5cwF62Iks5sv0CdgaJpZM4QGEDy .

lucasmation avatar Oct 25 '17 14:10 lucasmation

Que tal criar testes para verificar se os arquivos mudaram? Comecei um branch neste sentido. Desta forma automatizamos o processo de "keep track of the update status of each dataset".

Tinha feito um teste para verificar se os links funcionavam, mas podemos fazer outro para verificar se houve atualização nos dicionários.

tomasbarcellos avatar Oct 25 '17 16:10 tomasbarcellos

@tomasbarcellos É uma excelente ideia, também começamos algo nesse sentido:

  • https://github.com/lucasmation/microdadosBrasil/blob/master/vignettes/test_report_download.md
  • https://github.com/lucasmation/microdadosBrasil/blob/master/vignettes/test_report_import_sample.md

Os dois documentos são atualizados automaticamente pelos resultados de testes gerados pelas funções update_test_import_sample e update_test_download ( definidas aqui).

A dificuldade era que a necessiade de baixar todos os dados para executar o teste tornava inviável utilizar o travis, a sua solução parece ser melhor nesse sentido.

@lucasmation The idea is to have a central place where we can look for commits of this kind and check quickly when/how was the last time we updated each metadata. But yeah, maybe a Issue is not the best tool for this.

nicolassoarespinto avatar Oct 25 '17 18:10 nicolassoarespinto