caddy-supervisor icon indicating copy to clipboard operation
caddy-supervisor copied to clipboard

Supervisor and Caddy 2

Open johandalabacka opened this issue 5 years ago • 10 comments

Hi. More of a question than an issue. How are your plans to support Caddy 2?

johandalabacka avatar Dec 15 '19 00:12 johandalabacka

FWIW, I'd be interested in collaborating on an official (i.e. in the caddyserver organization) module for process supervision in Caddy 2. A lot of new and interesting possibilities here.

mholt avatar Dec 16 '19 04:12 mholt

@mholt That's very nice. I can update the readme page with links to the new module, let me know when you have a repo for it.

lucaslorentz avatar Dec 16 '19 06:12 lucaslorentz

Hi!

Is there any plans on this?

I really enjoyed this plugin on caddy v1 :)

@lucaslorentz if you don't have time / plan for it I think I could find some time to work on this.

@mholt are you still OK to make this an official module?

Baldinof avatar Jan 08 '21 15:01 Baldinof

@Baldinof I wasn't planning to work on it anytime soon. But I can help you if you need any assistance.

lucaslorentz avatar Jan 08 '21 15:01 lucaslorentz

are you still OK to make this an official module?

Yeah, we can depending on its popularity/usefulness -- I don't have much spare bandwidth to collaborate right now though. (My earlier comment was from well over a year ago!) The only difference is where the code lives, any repo will do - there's no technical difference.

Would be cool to see one!

mholt avatar Jan 08 '21 16:01 mholt

@mholt I have read the documentation and think i can do this. I would make a PR this weekend with a simple implementation to monitor a process

DanyHenriquez avatar Jan 27 '21 10:01 DanyHenriquez

Hi!

I totally forgot to respond here, I was planning to make a PR too but I don't know when I will find the time to finish it.

For the logging part, I think the processes outputs could be written in a specific log field. This way it could be sent to stdout / stderr via something like this:

log {
  format single_field "supervisor_stdout"
}

Baldinof avatar Jan 27 '21 11:01 Baldinof

(FWIW I intend to deprecate the single_field log encoder sooner or later.)

mholt avatar Jan 27 '21 18:01 mholt

So i see we want to use supervisor lib for this. Is there any library which has already been decided on?

DanyHenriquez avatar Jan 28 '21 08:01 DanyHenriquez

Remind me to upload some pictures I took of the Windows Task Scheduler this last week. (I'm waiting for GitHub to fix EXIF stripping before I post them here.) I think it has a lot of useful customization options that could be good inspiration for this kind of module.

mholt avatar May 05 '21 20:05 mholt