Lucas Ferreira comments

Results 70 comments of


                                            Lucas Ferreira

fix(remix-dev): allow defining multiple routes for the same route module file

Hi @AndrewLeedham I made a small change in the last commit in variable `id` (to `fileId`) name to clarify more what kind of id the automated. And also made more...

fix(remix-dev): allow defining multiple routes for the same route module file

> Nice work! I think it would be good if the docs are also updated, but maybe this can come later once the idea has been given the OK I...

fix(remix-dev): allow defining multiple routes for the same route module file

> @lucasferreira what's the easiest way to test this logic in my own app? I know thats weird but when I started develop this changes I worked directly inside de...

fix(remix-dev): allow defining multiple routes for the same route module file

> Perhaps docs is the blocker here? Maybe a commented example as part of https://remix.run/docs/en/v1/api/conventions#routes would help? Hi @AndrewLeedham I really don't know why this new feature/fix didn't got the...

fix(remix-dev): allow defining multiple routes for the same route module file

> Hey folks - sorry we are busy with some other things at the moment, but I think we were waiting on the change to remove the `${fileId}--${options.id}` logic based...

fix(remix-dev): allow defining multiple routes for the same route module file

> @lucasferreira I'd say error as early as possible, which should be in `defineRoutes`. That's where we'd inadvertently overwrite previous routes via `routes[route.id] = route` 👍 Hi @brophdawg11 and @AndrewLeedham...

fix(remix-dev): allow defining multiple routes for the same route module file

> > Could you add remix as an upstream remote locally and do a git merge or rebase? Hi @AndrewLeedham I really don't know how to do that 😫 I'm...

fix(remix-dev): allow defining multiple routes for the same route module file

That's was more easy than expected! Thank you very much @AndrewLeedham!

FEATURE REQUEST: Persistent FlashMessage

Hi @shawarmaz, I this case how user could dismiss the message? It will be always fixed at the top of the app? The only way to close will be if...

first commit for Lock Feature

Hi @PivaRos Thanks for your contribution, I thinking about `lock` term that you used there, I guess that your logic it's OK, but I will analyze this for more a...