now-deno icon indicating copy to clipboard operation
now-deno copied to clipboard

Published 20 hours ago • verified publisher icon lucacasonato

Specify deno-lambda version

Open hayd opened this issue 5 years ago • 9 comments

Atm now-deno uses the latest release but I think it would be good for users to (optionally?) pass a version number for the deno-lambda release to use.

(In the future this will match the deno version.)

hayd avatar Feb 03 '20 08:02 hayd

Should this be config.denoVersion? Is that the way to do this?

hayd avatar Feb 03 '20 18:02 hayd

I dont think that is the way. I think that is the legacy way for the 'builds' property - the new 'functions' property does not support config I think. The Node.js runtime uses engines.node in package.json and Go is just pinned to latest 1.x. We can probably pin to latest and let user specify a specific version via the env var DENO_VERSION - that should then 1:1 map to deno-lambda version. That env var can then be specified using build.env in now.json.

lucacasonato avatar Feb 03 '20 21:02 lucacasonato

I'll wait for https://github.com/hayd/deno-lambda/issues/20 to be done before implementing this.

lucacasonato avatar Feb 03 '20 22:02 lucacasonato

Mind if I grab this? I was working on delivering a PR for now dev but noticed it landed a little bit ago.

stephengfriend avatar Feb 03 '20 22:02 stephengfriend

Sure. Just be aware I won't merge it until https://github.com/hayd/deno-lambda/issues/20 is closed.

lucacasonato avatar Feb 03 '20 23:02 lucacasonato

That's totally fair. I wrote the tests to be compatible with it and I'm giving it a run-through, as well.

stephengfriend avatar Feb 03 '20 23:02 stephengfriend

https://github.com/hayd/deno-lambda/issues/20 is closed now: releases will match the deno version.

hayd avatar Feb 13 '20 04:02 hayd

@stephengfriend Do you still want to take this? If you don't want to anymore, I'll take it.

lucacasonato avatar Mar 05 '20 21:03 lucacasonato

Hey, thanks for checking in. I almost forgot about it. Yes, I'll take a look today.

stephengfriend avatar Mar 08 '20 16:03 stephengfriend