deno-puppeteer
deno-puppeteer copied to clipboard
Non try/catchable TimeoutError
Hi !
I found a weird bug : this error, that occurs in a timeout is not catchable with a try/catch clause around puppeteer.launch
.
let browser
try {
browser = await puppeteer.launch({ ...opts })
}
catch(e)
{
browser = await puppeteer.connect({ ...ws })
}
https://github.com/lucacasonato/deno-puppeteer/blob/45b3162585b98ad8d54abeb56f48ecbb17c614eb/src/deno/BrowserRunner.ts#L163-L165
This occurs while trying to launch a browser / user-data-dir couple a second time, chrome won't open a new instance but instead open a new page on the existing browser instance, and though don't output to stdout the ws endpoint as usual... The try / catch in fact work as expected, and connects to the instance instead in this case, but the sub task (out of scope) launch that failed will crash the process after 30s timeout not connecting... even if it was expicitely used in a try clause...