deno-puppeteer icon indicating copy to clipboard operation
deno-puppeteer copied to clipboard

Trouble installing chrome - this.proc.kill("SIGKILL")

Open ghost opened this issue 4 years ago • 2 comments

I get this

$ PUPPETEER_PRODUCT=chrome deno run -A --unstable https://deno.land/x/[email protected]/install.ts
Check https://deno.land/x/[email protected]/install.ts
error: TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'number'.
        this.proc.kill("SIGKILL");

Not sure on how to fix it since I would also imagine that it needs a number to keep a specific process.

https://github.com/lucacasonato/deno-puppeteer/blob/main/src/deno/BrowserRunner.ts#:~:text=not%20be%20found.-,if%20(this.proc%20%26%26%20this.proc.pid%20%26%26%20!this._closed)%20%7B,%7D,-//%20Cleanup%20this%20listener

ghost avatar Oct 21 '21 13:10 ghost

I get the same error. Not sure why and didn't get a chance to resolve this issue...

JoeLanglois avatar Oct 31 '21 14:10 JoeLanglois

I ran deno upgrade and after that, it no longer displayed that error. Hope this resolves this for you as well.

Caleb-Irwin avatar Jul 11 '22 19:07 Caleb-Irwin