Results 345 comments of Luca Bruno

This is a generic Kubernetes issue completely unrelated to this repository, possibly due to a malformed manifest. Closing this report and locking it to prevent attracting more unrelated followups.

@faiq ping :) This stale PR has been pending for some time, do you still want to proceed on this? If so, can you please address @yifan-gu comments?

@faiq I think it would be nice to have some portions of this. Point (1) looks good and point (3) makes the `Follow()` API more useful for the general case...

> regarding why we're sending interface{} through the channel, this is because the values on the fields can be json by something like https://github.com/wercker/journalhook and logrus. I'm not completely sure...

Thanks for the report. I agree it would be better to align all those methods to return proper `error` value. If you are interested in doing it, I'll gladly review...

@johannwagner thanks for the PR! However this lacks quite a bit of accompanying context, and on the surface it seems to just be trying to hide an existing race. What...

Generally speaking yes, I prefer handling separate PRs as they can easily travel at different speeds and merge at different times. So I'd use this only to fix #387, which...

We were having an out-of-band chat about this. I don't have any reference at hand, but I seem to remember this is in fact a corner-case of the interaction between...

Additionally, from an OS vendor point-of-view, we would like to able to ship default rules as part of the OS and keep them separate from user customized ones. An approach...

I also have a usecase where explicitly setting the permission mask (`0664` in my case) without relying on the default umask would be helpful. I think that having a new...