laravel-decomposer icon indicating copy to clipboard operation
laravel-decomposer copied to clipboard

feature/add-currently-installed-package-versions

Open sbramley opened this issue 7 years ago • 3 comments

First ever commit to open source :-O

Be gentle...

I've added a get contents method on the current composer.lock file, this should capture all the installed package versions then map them to the composer.json file so you can see not only what minimum requirements your package has, but what the currently installed version is as well.

sbramley avatar Dec 05 '17 05:12 sbramley

@sbramley Hey thanks for the PR, it's great 🙂 Few nitpicks:

  • Use camelCasing for variable names instead of underscores.
  • Remove that comment saying // reformat packages for easy reference
  • Put a space after foreach keyword
  • Rename the_package variable to just package

introwit avatar Dec 05 '17 06:12 introwit

@sbramley this looks neat :) Few final minor things, after that it's ready to be merged. Thank you for the contribution Sam 🙂

introwit avatar Dec 06 '17 05:12 introwit

@sbramley thanks for the PR, can you help us with the changes @introwit suggested and we are all good to merge it.

ajitbohra avatar Feb 13 '18 12:02 ajitbohra