zstd-jni icon indicating copy to clipboard operation
zstd-jni copied to clipboard

Add new qemu platform for riscv64 - 2nd try

Open Hamlin-Li opened this issue 1 year ago • 6 comments

Hi, Can you help to review this simple patch trying to https://github.com/luben/zstd-jni/issues/284 in github? (This is the 2nd try of https://github.com/luben/zstd-jni/pull/285) Thanks!

Hamlin-Li avatar Oct 31 '23 10:10 Hamlin-Li

Codecov Report

Merging #286 (00e8fc4) into master (89c7dcb) will decrease coverage by 0.15%. The diff coverage is n/a.

:exclamation: Current head 00e8fc4 differs from pull request most recent head 941302e. Consider uploading reports for the commit 941302e to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
- Coverage     59.74%   59.60%   -0.15%     
  Complexity      301      301              
============================================
  Files            26       26              
  Lines          1421     1421              
  Branches        164      164              
============================================
- Hits            849      847       -2     
- Misses          417      419       +2     
  Partials        155      155              

codecov-commenter avatar Oct 31 '23 10:10 codecov-commenter

that doesn't look to work and also breaks the s390x tests

luben avatar Oct 31 '23 21:10 luben

Yes, both riscv and s390x encountered below issue:

/github_workspace/sbt-java-module-info /github_workspace
Downloading sbt launcher for 1.9.0:
  From  https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/1.9.0/sbt-launch-1.9.0.jar
    To  /root/.sbt/launchers/1.9.0/sbt-launch.jar
Downloading sbt launcher 1.9.0 md5 hash:
  From  https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/1.9.0/sbt-launch-1.9.0.jar.md5
    To  /root/.sbt/launchers/1.9.0/sbt-launch.jar.md5
cat: /root/.sbt/launchers/1.9.0/sbt-launch.jar.md5: No such file or directory
md5sum: 'standard input': no properly formatted MD5 checksum lines found
Checksum does not match
Could not download and verify the launcher. Obtain the jar manually and place it at /root/.sbt/launchers/1.9.0/sbt-launch.jar
Error: Process completed with exit code 1.

But I can access https://repo1.maven.org/maven2/org/scala-sbt/sbt-launch/1.9.0/sbt-launch-1.9.0.jar.md5. Not sure what causes the issue.

Hamlin-Li avatar Nov 01 '23 08:11 Hamlin-Li

Can you try to rebase it - I have updated the sbt used by that plugin, so may be it will not fail with the new version

luben avatar Nov 01 '23 13:11 luben

Seems we still face the same issue.

Hamlin-Li avatar Nov 01 '23 13:11 Hamlin-Li

Fails again. s390 workflow getting cancelled due to the other task failure. Can you add strategy: fail-fast: false to let it run to completion?

luben avatar Nov 01 '23 13:11 luben