luau icon indicating copy to clipboard operation
luau copied to clipboard

Implement RFC, rename tag "class" to "extern" locked behind a flag, tenary operator

Open karl-police opened this issue 5 months ago • 7 comments

Implementation for https://github.com/luau-lang/rfcs/pull/131 incase it gets merged

It's like https://github.com/luau-lang/luau/pull/1926, but different

karl-police avatar Jul 23 '25 15:07 karl-police

This is the correct way to do it, not the other way, but it needs a rebase. The flag should not be a debug flag.

aatxe avatar Aug 21 '25 21:08 aatxe

Hmm, without Debug at the front. I wonder if this will error out Unit Tests that use :is("class"), most likely yes

karl-police avatar Aug 21 '25 23:08 karl-police

I guess there are no Unit Tests.

karl-police avatar Aug 21 '25 23:08 karl-police

you should flag those tests to change to using extern when the flag is enabled

aatxe avatar Aug 21 '25 23:08 aatxe

you should flag those tests to change to using extern when the flag is enabled

the new one?

karl-police avatar Aug 21 '25 23:08 karl-police

not if it's new, but if there were any existing tests, you'd flag them to reflect the change

aatxe avatar Aug 22 '25 17:08 aatxe

not if it's new, but if there were any existing tests, you'd flag them to reflect the change

It doesn't look like there were, and if there were it would have failed the build checks. But for future changes, I will look out for that. (Well, if the build fails I have to fix it regardless)

karl-police avatar Aug 22 '25 21:08 karl-police