luarocks-site icon indicating copy to clipboard operation
luarocks-site copied to clipboard

Support username change

Open binkoni opened this issue 5 years ago • 4 comments

Added username change support

binkoni avatar Apr 27 '19 03:04 binkoni

Hmm.. no plan to support this?

binkoni avatar Nov 20 '19 05:11 binkoni

sorry, I must have missed this pull request. Looking over it

leafo avatar Nov 20 '19 17:11 leafo

Changing usernames can break URLs to manifests & packages.

  • Minimally we should have a big warning about changing your username, explaining why it might not be a good idea
  • We can set up an automatic redirect for the old username to the new username (both for profile pages, and manifest/package urls)
    • A new model would need to be created, UserRedirects or something similar
  • On other sites where I've implemented username changing, I tend to keep the old username locked. This means preventing an account using a previously used username to stop hijacking any old URLs. I think this is especially important for a package manager.

leafo avatar Nov 20 '19 18:11 leafo

@leafo Thanks for the response. Since it seems to take some time, I'll implement what you said when I have some time.

binkoni avatar Nov 23 '19 10:11 binkoni