hapi-universal-redux icon indicating copy to clipboard operation
hapi-universal-redux copied to clipboard

Published 20 hours ago • verified publisher icon luandro

Upgrade to React Hot Loader

Open drouillard opened this issue 8 years ago • 3 comments

Attempt to address #99

I didn't remove the old hot loading module quite yet. Hot Loading did not work in general for me on OS X / Node V5 and V6 until I made this update. If this works for you feel free to merge. I can remove the old hot module reloading code with another PR. I tried originally but ran into some issues that I have since had trouble reproducing.

I also updated package.json to fix eslint config. The peer deps for Airbnb config were not being met.

drouillard avatar Jul 28 '16 17:07 drouillard

Seeing errors again on server - which is interesting since I made changes to client webpack

[HMR] Cannot apply update. [0] [HMR] Error: Aborted because 3 is not accepted

Server is having to restart to work. The client side hot reloading still seems to work? Will continue investigating

drouillard avatar Jul 28 '16 18:07 drouillard

Actually I am seeing the HMR errors on the server even on a fresh pulldown of this project before my commits. It still works, just seems to restart the server.

drouillard avatar Jul 28 '16 19:07 drouillard

For the linting errors I was seeing - similar issue

https://github.com/facebookincubator/create-react-app/issues/275

Looks like eslint in command line could work. I use mine via Atom editor plugin which requires explicit inclusion.

drouillard avatar Aug 02 '16 11:08 drouillard