ltzmaxwell
ltzmaxwell
>Also can this PR be broken down? I actually hoped to do this. This PR proposed an improved flow for the type check, and solved several cases of problems based...
>Or before that, how about we sync by voice or txt? I'll be looking at this & https://github.com/gnolang/gno/pull/1501 concurrently. Also please check this comment: https://github.com/gnolang/gno/issues/1424#issuecomment-1887857271 Yes, sure!
Hi @piux2 , Thank you so much for your time in reviewing this!! > It seems there are multiple intents for this PR, accompanied by a lot of code changes....
WIP to break down into separate ones. block until done.
> @ltzmaxwell What is the status of breaking up this PR? it’s almost done, making final confirmation.
Update: The original #1426 is now divided into 4 parts, with the dependency relationship being: #1426 < #1775, #1426
> > 2. Modifications have been made to checkOrConvertType to add conversion checks for constants, such as int(1) + int(8), which previously would not trigger a compile-time error; > >...
> @ltzmaxwell can you check, do we have some over lapping work with #1141 #1246 #1143? thanks! Hey @piux2 , I think they have different intentions, that the work in...
> @ltzmaxwell can you resolve the conflicts with the main branch? this is resolved.
> Sorry it has taken so long to review; I had to carve our some dedicated time to focus on this. I primarily reviewed the code in `type_check.go`. I will...