Louis Thibault
Louis Thibault
>But I am thinking forcing the promise for value shouldn't be done through invokable just because it might be confusing Agreed. >We could use the Clojure approach may be? (deliver...
LGTM. I agree with both points regarding the integration of special forms into `Runtime`. Regarding `runtime.New`, any particular reason you're leaning towards `int32` flags? I'm guessing some of the bits...
@spy16 Just wondering: does anything else still need implementing, or can we begin the formal code-review/merge process?
@spy16 can we get rid of the `strings.TrimSpace` in [repl.WithBanner](https://github.com/spy16/sabre/blob/runtime/repl/options.go#L71)? It's interfering with my template, which specifies a newline at the end. Right now my banner looks like this: ```bash...
@spy16 I have some spare cycles beginning next week -- is there anything I can do to help move this forward? This is becoming a bit of a blocking issue...
@spy16 I'm terribly sorry to hear about your father! I'm glad he's alright now, although you and your family must still be reeling from the shock. By all means take...
Regarding tests: this suggestion was previously discussed, and I recall @spy16 was opposed to moving tests into the same package as code. IIRC, his position was that placing tests in...
I'm not sure I see where temporary packages or changes to `go.mod` are needed. In case it helps identify a misunderstanding, my mental model for your workflow is this: 1....
>Remember that I need to be able to test and use leifj/sabre as a dependency of other projects while we talk about PRs etc Aha! This was the missing piece!...
Hi @leifj, 100% agree with this. It was brought up in a previous issue (which I can't seem to find for some reason), and I think @spy16 was also onboard....