ltamasi

Results 17 comments of ltamasi

Some more stats about overall cache misses as discussed with @siying : Baseline: ``` rocksdb.block.cache.miss COUNT : 371740 rocksdb.blobdb.cache.miss COUNT : 111060940 rocksdb.block.cache.miss COUNT : 371571 rocksdb.blobdb.cache.miss COUNT : 111062668...

@mdcallag Thanks for filing this. I think we're in the clear when it comes to the cache-level metadata (size of LRUHandle + cache key), since that's handled by the LRU...

Landed a patch that will hopefully fix this in 23376aa5766ff486df666896809ccac38227fbd0. With this change, the charge for blobs inserted into the cache will also take into consideration the size of the...

Thanks so much for implementing this feature @gangliao !

A few things to note here: 1) BlobDB's GC is integrated into the LSM tree compaction process. It doesn't actually "rewrite blob files" in the sense of iterating through all...

> In a real-world database, pure-insertions are un-predictable, in db-bench or testing, we may turnoff garbage collection, but in real world, user behaviors are unpredictable, how can we turn it...

#11982 is actually the initial patch for supporting wide columns in `WriteBatchWithIndex`. Wide columns themselves have been around since RocksDB 7.9 (https://github.com/facebook/rocksdb/blob/main/HISTORY.md#new-features-10) and the existing APIs are stable; we will...