Martin Århof

It fails in `FormErrorNormalizer` - missing return statements - missing getSupportedTypes function. ``` public function getSupportedTypes(?string $format): array { return [Form::class]; } ``` ``` public function supportsNormalization($data, $format = null,...

@DjordyKoert I just updated to not use the Choice assert.  Though the swagger is still the same 

Because PHP is better than javascript to compare floats, sometimes it fails the server validation even though the javascript validates it.

I dont know how to only pass the argument in the service, in Symfony 2.4 it would be something like this ``` xml @=container.hasParameter('mopa_bootstrap.flash.closeable') ? parameter('mopa_bootstrap.flash.closeable') : false ``` But...

Now if `session_flash(true)` is called, the X is always showed regardless of the config If `session_flash()` is called, and no config is set, it will not show the X. If...

Well, mostly Im fan of getters and setters, and not passing everything to the contructor - but well its a personal reference :)

Remember $this->closeable is always set as either true or false (false is standard) Im pretty sure |default only gets called when the return value is null

So in the twig you want ``` {% if close is null %} {% set close %}{{ mopa_bootstrap_flash_closeable() }}{% endset %} {% endif %} {{ flash_messages.flash(mapping[type], message, close, use_raw, class,...

The second is so much more readable - the first is really hard to see what its actually does imo

Yes, thats actually what the test is doing.