functional-php icon indicating copy to clipboard operation
functional-php copied to clipboard

Migrate to PHP 8.4

Open redbeardcreator opened this issue 1 year ago • 5 comments

This is in response to my bug report, #254 . However, it technically also "competes" with:

  • #253
  • #255 I believe this is more thorough than either of the other two PRs. And it answers #254 and then some.

I made these changes before I knew about the other two. But I'm tired and want to get this PR in. If desired, I'm happy to do the work of merging the other PRs together so everyone gets credit.

redbeardcreator avatar Dec 09 '24 07:12 redbeardcreator

Incidentally, I made these changes against the 1.17.0 release rather than main. I'll be maintaining my fork until PHP 8.4 support is merged, as I will be going to production with 8.3 (at least) soon.

redbeardcreator avatar Dec 09 '24 07:12 redbeardcreator

Looks good! Care to extend the build matrix for CI as well?

lstrojny avatar Dec 12 '24 10:12 lstrojny

is there any info when new version will be released with support of php 8.4?

SergeyKhrystenko avatar Feb 07 '25 14:02 SergeyKhrystenko

no, but you can use my PR. I work with itОтправлено с iPhone7 февр. 2025 г., в 19:50, Sergey Khrystenko @.***> написал(а): is there any info when new version will be released with support of php 8.4?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Egorskov avatar Feb 07 '25 14:02 Egorskov

@redbeardcreator any chance you'll be able to address the comments by @lstrojny? so he can finally merge the PR and release a new version 😄

GabMar avatar Apr 11 '25 09:04 GabMar