Lincoln Stein

Results 352 comments of Lincoln Stein

I just noticed that the changes to the way VRAM loading is handled is consuming more memory than it should. I’m going to revert to the current method and work...

I have fixed the "test_deny_nodes()" test so that it doesn't interfere with later tests. The fix involved clearing the config cache after the test finishes running so that the `allow_nodes`...

> Thanks! It looks like this picked up the config migrator though, need to wait for that to merge before this PR can merge. Or bring the changes in this...

Mistakes happen and some users will end up with a model config in the database but missing model files. The system will complain at startup. What is the user to...

> I added a failing test case that should pass with stricter migration version logic. This test fails on `main` too, but I'd like this PR to improve on the...

@psychedelicious I updated the `test_deny_nodes()` test, which was marked as `xfailed`. It seems to work as expected now, both in isolation and as part of the full test suite. It...

> > It looks like there used to be schema validation tests in the Graph class, but I don't see them in there any longer, so I removed the Graph...

> > In the new test case, I don't understand why this config is expected to fail: > > This should fail bc 4.0.1 isn't a valid registered config schema...

> > I'm still not following; maybe it's too late at night. The current schema version in main (and this PR) is 4.0.1 and there are two migrators defined, one...

@psychedelicious When you have a chance, please give this the once-over. I've converted the migration class into a migration instance, but I'm not sure I did this in the most...