Lincoln Stein
Lincoln Stein
> Ok, I've revisited this PR and made some changes, simplified a few things and made the tests more rigorous. I'm not entirely convinced the extra complexity in this change...
@psychedelicious At this point I think it's easier just to add ad hoc code to the `load_and_migrate_config()` function. Unless you object, I'm just going to close this PR.
This looks like a cul-de-sac and I'm closing it.
@psychedelicious This is ready for your review now. There are now just two calls: `load_and_cache_model()` and `download_and_cache_model()` which return a locally cached Path and LoadedModel respectively. In addition, the model...
@psychedelicious I just updated the whole thing to work properly with the new (and very nice) Pydantic-based events. I've also added a new migration. Please review when you can. I'm...
@psychedelicious I've addressed the remaining issues you raised. Thanks for a thorough review.
> I removed a number of unnecessary changes in `invocation_context.py`, mostly extraneous type annotations. If mypy is complaining about these, then that's a mypy problem, because all the methods are...
> > Yes, mypy is having trouble tracking the return type of several methods. I haven't figured out what causes the problem and don't want to add a # type:...
@RyanJDick I've fixed the issues you identified.
Indeed most of these are just single file checkpoints, but HuggingFace gives them the same file name. The enclosing folder name is used during probing to get a name for...