jupyter_tensorboard icon indicating copy to clipboard operation
jupyter_tensorboard copied to clipboard

Fix compatibility with TB >= 2.2

Open cliffwoolley opened this issue 5 years ago • 9 comments
trafficstars

https://github.com/tensorflow/tensorboard/pull/3539 in TensorBoard 2.2 dropped the legacy DB mode, so the unused optional db_* parameters to base_plugin.TBContext() should be dropped, as in https://github.com/tensorflow/tensorboard/commit/628b78fe3efbd98df84410a8841ff96fefa3beac#diff-9f7ffee070d3d2429db0b7178d355ec6L229-L241

cliffwoolley avatar May 31 '20 06:05 cliffwoolley

/cc @wchargin

cliffwoolley avatar May 31 '20 06:05 cliffwoolley

Why is this not merged already? Bumped into this issue.

leonardschneider avatar Jul 03 '20 16:07 leonardschneider

I've updated this PR from last year to also include TB 2.3 and TB 2.4 now.

Plus the newer, simplified implementation should allow better future-proofness as well: Instead of pulling out a huge chunks of the entry function to TensorBoard (which by the way no longer exists in TB 2.4) and reimplementing it mostly just to catch the returned object to add to our tensorboard_manager; instead we now just wrap the unmodified TB function from the outside and add to the tensorboard_manager that way. Also we no longer attempt to implement any special multiplexing functionality since TB handles all that on its own and the threading being handled in two places was causing bugs.

cliffwoolley avatar Feb 05 '21 01:02 cliffwoolley

Thanks for this fix... It helps me a lot

rvernaeshv avatar Mar 11 '21 10:03 rvernaeshv

@lspvic can we merge this?

wexder avatar Apr 06 '21 11:04 wexder

This seems to be working with TB 2.5 as well, fwiw.

cliffwoolley avatar May 28 '21 20:05 cliffwoolley

just tried this with TB 2.7 and it worked very well. amazing! thanks for the fix. why has it not been merged already?

billshitg avatar Dec 12 '21 17:12 billshitg

@lspvic Could you please merge this feature to master and bump up the library version?

videodanchik avatar Jan 28 '22 16:01 videodanchik