Louis comments

Results 206 comments of


                                            Louis

Bad values time_flow_start_ns, time_flow_end_ns when sending Newflow v9 and exporting them to Kafka

Hello, Thank you for reporting but It will be difficult to troubleshoot without actual capture. Was the replay done at 18:52: does pmacct discard the timestamp by ang chance and...

Bad values time_flow_start_ns, time_flow_end_ns when sending Newflow v9 and exporting them to Kafka

I'll have a look at the code, it seems the (correct) calculation is ``` Current time - sys uptime + first_switched 1710341553 - 1047938 + 1047878 = 1710341493 ``` where...

Bad values time_flow_start_ns, time_flow_end_ns when sending Newflow v9 and exporting them to Kafka

Could you have a look if https://github.com/netsampler/goflow2/pull/325 solves your issue? The buggy calculation was ``` 1710341553 - 1047938855 + 1047878797 ``` The correct calculation was ``` 1710341553 - 1047938.855 +...

Implement boolean field

@swontroba will take a look. Could you give me more information about the problems with the list?

chore(decoders.sflow): Cleanup constant definitions and use switch statements

Thank you! will have a look. I wouldn't be too worried about removing instead of deprecating (I may forget to do it next large version bump).

chore(decoders.sflow): Cleanup constant definitions and use switch statements

Yes please go ahead with the removal! Thank you :) For the other, would you be able to add tests and provide me with a packet capture?

chore(decoders.sflow): Cleanup constant definitions and use switch statements

@srebhan I just need to find some time to take care of it :), thank you

chore(decoders.sflow): Cleanup constant definitions and use switch statements

I'm sorry it took so long to review. I just merged the three PRs. Thank you for the great work.

Fix.listen ipv6

Thank you for the details I could have reopened #316 but will move forward with this one once I check it

Fix.listen ipv6

Ok I dived into the code. Would be great to also add ways to break the application. Ended up finding a different bug and was fearing a regression. * it...