Clojush icon indicating copy to clipboard operation
Clojush copied to clipboard

Should the JVM settings in project.clj be in a separate file?

Open NicMcPhee opened this issue 10 years ago • 1 comments

I might be completely up a tree here, but I find the section in the default project.clj with all the commented out JVM options at best awkward. Having commented out options like that encourages people to include even more commented out lines, and makes managing things like commits difficult. If I think my project needs the 12gb option and I make that change, I presumably want to commit it to my fork. But then I probably don't want to try to push that change up to this "master" repo, which potentially requires some cherry picking if I make some change in that file that I do want/need to pass along.

Being fairly new to the codebase, I don't have a great sense of how often project.clj changes. I'm guessing parts, like the description and license, change quite rarely. Other parts, like the JVM options and dependencies, seem like things one might fiddle with quite a lot while getting a project up and running. If I'm right about that, maybe those bits that change a lot could/should be pulled out into separate files so they can be modified and managed separately. These could then be pulled in by project.clj in one place that then doesn't change.

Alternatively could/should those settings go in your project specific file, like simple_regression.clj?

Does that make any sense?

NicMcPhee avatar Sep 17 '14 13:09 NicMcPhee

There was a general sense at today's meeting that there is room for improvement here. Maybe @thelmuth and I should get together and talk about how we might address this.

NicMcPhee avatar Sep 17 '14 14:09 NicMcPhee