lsiepel

Results 308 comments of lsiepel

I think you accidentally merged upstream commits in the wrong way, now you have to rebase. _Don't use "git merge" when working with your pull request branch! This can clutter...

Nice you managed to fix the rebase. The build is failing because the binding was not added to : bom/openhab-addons/pom.xml yet. Also don't forget to add yourself to the codeowners...

> Oh sorry, I totally missed the new comments - I'll have a look! Appreciate your patience and help as this is my first time working on a new binding...

Hopefully you can address the last comments so we can proceed and merge this PR. If you need any help, please let me know.

To determine the cause, it might be usefull to look at what was changed. From what i understand the issue/regression was introduced by 3.2 So [here is a list of...

If you can fix the merge conflict, i can do a first review.

@volfan6415 last commit is 6 months old. Are you able to finish the binding?

ping @volfan6415 do you plan to finish this PR?

Not in the list, but could denonmarantz binding also be affected? See https://github.com/openhab/openhab-addons/issues/15444#issuecomment-1683958966

> @Skinah The channels directly match names as received from the xml. I could built in a translation function (e.g. replace _ with next letter capital). Also I use a...