lsiepel
lsiepel
> which class should I log to trace in my log4j2.xml ? org.openhab.binding.avmfritz Maybe the console or UI is more convenient, choose your favorite way: https://www.openhab.org/docs/administration/logging.html
> Please read #12262 Have adjusted the tags as much as possible to the guidelines, let me know if something is not yet compliant.
> > Have adjusted the tags as much as possible to the guidelines, let me know if something is not yet compliant. > > Yes please again the rule number...
Gentle ping @lolodomo do you see some tag issues here left to fix? I'm in the understanding everything is fixed.
I think it is ready for a review. I tried to add the upgrade instructions, but have some questions as this is a new feature and the documentation might need...
> > * Why is the channel type mandatory? As this is not changed. Isn't the channel-id enough? > > * The XML definition seems to lack a category element....
Splitted this PR, ready for a review, sorry for all the clutter.
> > Review of the update instructions: (...) Also you need to add the `thingTypeVersion` property, otherwise the migration will not be triggered. Please see [#15294 (comment)](https://github.com/openhab/openhab-addons/pull/15294#discussion_r1274150623) and test the...
@lolodomo can you look at the tags? Would be appreciated.
Gentle ping @openhab/add-ons-maintainers