Gerwin Klein

Results 636 comments of Gerwin Klein

@abrandnewusername Are you working on this or did this just get assigned to by accident? (It's fine if not, then somebody can take it over)

> > Gerwin> I don't think we have a decided value for > > Gerwin> markdown/documentation wrap. We have 120 for C and 100 for > > Gerwin> Python, so...

I have rebased the PR and addressed the review feedback as far as I could (so far in a separate commit, to be squashed before merging). There are still a...

Ping: @yyshen and @wom-bat are you happy for this to be merged? (You don't have to do a full re-review -- if you're happy for the open questions to be...

This has gotten quite old and no reply, which is entirely undeserved. I think this is a very good idea. If you're still interested, we'd be keen so see a...

I'm not deep enough in the RISCV details to review this one, but I am in favour of the general idea.

(I don't think the mode reset is intentional by `cmake-format`)

> I guess the CI failure here is from the CI environment using the older version of `sh`... since it's only used minimally and is a self-contained single-file no-deps thing,...

> There are many ways to solve this, but currently the ideal way is to check which version of sh is installed and then use the right method. This would...

As a meta observation: it looks like we need a better see all minimally necessary checks passing when we accept a platform port. Currently, we need the platform to exist...