Don Setiawan
Don Setiawan
My first attempt to handling these conventions is creating a yaml file that somewhat describe the convention in https://raw.githubusercontent.com/OSOceanAcoustics/echopype/e445cda7cec8ea703ec6bcd6205186ee9a463c82/echopype/echodata/convention/1.0.yml. I am currently using that file to dynamically create the attributes...
See https://github.com/OSOceanAcoustics/echopype/runs/8218144386?check_suite_focus=true#step:11:94. Now CI installs the correct version. Thanks for catching this.
This PR is not quite ready... not sure why CI is failing.
Now with the new parallel way to convert, this doesn't seem necessary atm.
So many of these descriptions everywhere! I didn't notice that the sentence was funky until now. Thanks for pointing that out @b-reyes. I definitely agree that we should be using...
This suggestion came from https://github.com/OSOceanAcoustics/echopype/pull/493#issuecomment-974294527.
> "pre load it" always just once, automatically? Or do you think having to read the yml several times is not a big deal? I think pre loading it is...
If it's an xarray Dataset object, all you need is `Dataset.to_zarr(consolidated=True)`
Should be all the groups I think. @emiliom @leewujung , Do you guys have any thoughts on this?
@b-reyes consolidated needs to be True for zar to consolidate. I think all you need is to make sure that every Dataset.to_zarr has the consolidated=True flag. Shouldn't be much to...