capistrano-elbas icon indicating copy to clipboard operation
capistrano-elbas copied to clipboard

Published 20 hours ago • verified publisher icon lserman

Update default version of launch template

Open madmatvey opened this issue 4 years ago • 4 comments

create_launch_template_version doesn't update default version of launch template. But at logger info we can see:

[ELBAS] Updating launch template with the new AMI...
[ELBAS] Updated launch template, new default version = 14

It is not true. I've added this PR to fix it :)

madmatvey avatar Sep 29 '20 15:09 madmatvey

Hey, I'll look into getting these merged. Haven't maintained this repo in awhile. Think you could add a test here? Looks like there is a test for this but it must be wrong. Thanks!

lserman avatar Sep 29 '20 16:09 lserman

Hey, I'll look into getting these merged. Haven't maintained this repo in awhile. Think you could add a test here? Looks like there is a test for this but it must be wrong. Thanks!

Give me a few moments, just start my production tests :) and already have some corrections.

madmatvey avatar Sep 29 '20 16:09 madmatvey

@lserman tests done. May be this repo needs to setup a CircleCI? It may be more informative when tests was falling red with GH integrations. Screenshot 2020-09-30 at 00 40 11

madmatvey avatar Sep 29 '20 20:09 madmatvey

@lserman can you merge this ? I also tested on my aws machines and default version gets updated

duleorlovic avatar Jan 18 '21 23:01 duleorlovic