lselden comments

Repositories
Issues
Comments

Results 13 comments of


                                            lselden

SAM extension

> @lselden Those features sound great! I can't seem to find your fork though; could you provide a link? Whoops! Yeah it's here: https://github.com/lselden/extensions/tree/sam

> you should not leak `SamJs` to global, this is bad practice, a more indepth review will be required CC: @lselden @MagentaDude I submitted [a PR](https://github.com/MagentaDude/TWextensions/pull/1) to your fork the...

OAuth

Encouraging anyone to expose their OAuth client secret isn't good practice. Consider changing this to use a [PKCE flow](https://auth0.com/docs/get-started/authentication-and-authorization-flow/authorization-code-flow-with-pkce) instead - it only requires a client ID and the redirect...