sgx-lkl icon indicating copy to clipboard operation
sgx-lkl copied to clipboard

Published 20 hours ago • verified publisher icon lsds

Test samples in CI

Open letmaik opened this issue 4 years ago • 4 comments

Samples are not tested in CI and will inevitable break over time if they are not run manually regularly. They should be tested in CI, which may simply be a crash test.

letmaik avatar May 11 '20 13:05 letmaik

Example of where this would have helped: https://github.com/lsds/sgx-lkl/issues/514. We really need to test samples in CI.

letmaik avatar Jun 24 '20 06:06 letmaik

+1. I think this should be p0, it's the first thing prospective users will try!

wintersteiger avatar Jun 26 '20 10:06 wintersteiger

Enhancing test coverage with the samples will help to discover bugs and stability issues. I think this issue should stay as P1.

bodzhang avatar Aug 17 '20 13:08 bodzhang

The samples almost completely overlap with the existing CI tests.

prp avatar Aug 17 '20 13:08 prp