lsd
lsd copied to clipboard
fix: directory name ending with extention are not prepended with ext …
Tried fixing #965
TODO
- [x] Use
cargo fmt
- [x] Add necessary tests
- [x] Update default config/theme in README (if applicable)
- [x] Update man page at lsd/doc/lsd.md (if applicable)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: atamakahere-git
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.54%. Comparing base (
ee2d12b
) to head (f4041c4
).
:exclamation: Current head f4041c4 differs from pull request most recent head 0bad9f3. Consider uploading reports for the commit 0bad9f3 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #973 +/- ##
==========================================
+ Coverage 84.34% 84.54% +0.19%
==========================================
Files 53 51 -2
Lines 5111 5078 -33
==========================================
- Hits 4311 4293 -18
+ Misses 800 785 -15
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In macOS, directores with extensions do have special meanings. For example, /Applications/Google Chrome.app
, /System/Library/System.framework
I will do some research/tests and get back on this, If any suggestion let me know.
@CarterLi Hey, I did some changes that exclude special named directory.
@zwpaper Hey, are you thinking of adding this enhancement to lsd?