lsd icon indicating copy to clipboard operation
lsd copied to clipboard

Published 20 hours ago • verified publisher icon lsd-rs

human readable flag (-h) enabled

Open sdorr0 opened this issue 2 years ago • 6 comments

This re-enables a quick, easy to type command line flag that ls users are familiar with for convenience.

In the event a user has changed the default configuration of lsd to use a size setting of something other than default, this lets a user use the historically established CLI flag (-h) to enable the human readable option without having to type --size=default on the command line.

TODO

  • [x] Use cargo fmt
  • [x] Add necessary tests
  • [x] Add changelog entry
  • [x] Update default config/theme in README (if applicable)
  • [x] Update man page at lsd/doc/lsd.md (if applicable)

sdorr0 avatar Sep 17 '23 00:09 sdorr0

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdorr0

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

muniu-bot[bot] avatar Sep 17 '23 00:09 muniu-bot[bot]

hi @sdorr0, thanks for the contribution.

I have one more question, what is users used -h with --size option? this would make --size not working?

zwpaper avatar Sep 17 '23 07:09 zwpaper

hi @sdorr0, thanks for the contribution.

I have one more question, what is users used -h with --size option? this would make --size not working?

Hmm. Yeah, the way the code is written now, -h will override a --size on the command line. I see that subsequent --size flags on the command line will override one another based on position (the 'last' one wins).

Never done Rust before. I'm not sure if there's a way to set up #[arg()] to also incorporate a short -h so it can play nicely with those positional dependencies, but I can research.

Would this be a requirement to merge this change in?

sdorr0 avatar Sep 17 '23 18:09 sdorr0

I may have a solution

sdorr0 avatar Sep 17 '23 19:09 sdorr0

Never mind. I've tried all kinds of approaches and can't seem to get clap to let -h work with --size=<mode> where the last one on the command line always wins.

So, yes, using -h will take precedence over a supplied --size=<mode> argument.

sdorr0 avatar Sep 17 '23 20:09 sdorr0

but it does not make sense for -h as a general flag to overwrite the --size as a specific flag.

many people may set the -h as default and it may lost --size if that

zwpaper avatar Sep 18 '23 15:09 zwpaper