lsd icon indicating copy to clipboard operation
lsd copied to clipboard

Windows support for `.config/lsd`

Open Fleshgrinder opened this issue 3 years ago • 7 comments

On Windows lsd only looks at %APPDATA%/lsd and ignores %USERPROFILE%/.config/lsd. This platform difference makes it unnecessarily harder to write portable dotfiles across several platforms. It would be great to reconsider this stance and ensure that all platforms behave the same way.

Fleshgrinder avatar Oct 29 '22 09:10 Fleshgrinder

We could probably look into %USERPROFILE%/.config/lsd if no config was found at %APPDATA%/lsd.

meain avatar Nov 03 '22 14:11 meain

Cross platform XDG_CONFIG_HOME / XDG_CONFIG_DIRS support would be useful either in addition or instead of this change.

Maybe just search for the 'lsd' path from the within a path list such as "%XDG_CONFIG_HOME%;%XDG_CONFIG_DIRS%;%APPDATA%;%USERPROFILE%\.config".

rivy avatar Jul 18 '23 15:07 rivy

+1 for XDG support on WIndows also - not sure why it's not. Bunch of cross-system CLI apps have it implemented well - prioritize XDG everywhere, then go for system specific locations such as %APPDATA%. E.g. most git related CLI apps and some of similar utility ones. This way you can point it at e.g. a cloud synced folder to have the same configs on multiple systems/devices.

Any opinion @meain?

Destroy666x avatar Sep 19 '23 21:09 Destroy666x

/help /milestone v1.1.0

zwpaper avatar Sep 20 '23 01:09 zwpaper

@zwpaper: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help /milestone v1.1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

muniu-bot[bot] avatar Sep 20 '23 01:09 muniu-bot[bot]

@zwpaper I'd be happy to write up a PR for this if you still need help

ofersadan85 avatar Dec 31 '23 16:12 ofersadan85

thanks so much, @ofersadan85, it would be great that you could help, I will look into the PR ASAP and then we could release the v1.1.0

zwpaper avatar Jan 03 '24 11:01 zwpaper