lsd
lsd copied to clipboard
lsd-rs
--icon-theme unicode showing only questionmarks
Hi, thanks for a great tool!
lsd is working well for me with Nerd Fonts set up.
However, it might be even prettier if it actually used the colorful unicode icons, e.g. 📁.
I would have guessed that lsd --icon-theme unicode would achieve that, but it only shows question marks for me:
This is lsd 0.20.1 installed using brew on macOS Big Sur 11.6.1 (running on an m1 MacBook) running inside iTerm2 3.4.12 (but it behaves the same in Terminal 2.11).
I am able to display unicode icons using echo
Is this a bug, or is there some configuration I need to do?
did some investigation, looks like a bug, unicode has fewer use cases, maybe need some check and updates.
Also came here to report this. In both iTerm and Kitty I'm using a font called Ricty Diminished with Fira Code, it is basically a Fira Code offshoot that supports Japanese text.
In iTerm, for whatever reason its all question marks. In Kitty, it sometimes ends up appearing as Chinese/Japanese characters.
Here's some screenshots from iTerm.
Here's some screenshots from Kitty.
I'm on a 2019 Intel Macbook Pro running Macos Monterey. lsd was installed using brew.
Hi @mcaubrey, thanks for the report, but It seems that you were facing a different problem with the font, lsd have to use a patched font with emoji support, please check https://github.com/Peltoche/lsd#prerequisites.
@zwpaper I'm just reporting back to say you were right, the steps suggested on https://github.com/Peltoche/lsd#prerequisites have worked perfectly for me.
Just gentle reminder that the original issue was actually not the same as that of @mcaubrey and the fix for his problem did not fix the original problem.
Hi @Mellbourn, sorry for the later reply, I finally found out that the Unicode we used in lsd is version 7.0, and it may have some render problems.
I can reproduce it on my mac, but not yet figured out how to render the 7.0 unicode.
for example:
- we used the folder 1F5C0 it also does not render well in my browser
- I try to use a previous version one 1F4C1, it works as expected.
BUT! please notice, unicode icon theme is not well implemented, we only have the file and folder icons.
@meain how about we change the default Unicode back to version 6, it may add much more compatibility to lsd.
also, BTW, I am trying to work on the icon theme, I may leave a seat for unicode theme, then it will have a chance to create a custom unicode icon theme.
Just a personal opinion, switching to 1f4c1 drops the "terminally" feeling as it looks more like an emoji. If we can find something that will let us do without it, that would be better. Lot of terminal emulators also have problems with rendering multi colored glyphs and so using emojis might not be a good idea in that case as well.
although I am not one of the target users, the Unicode option is designed to act like that with colorful glyphs?
check starship for example
I think if we can stick to non color glyphs, it would be better. But since unicode is more of a fallback (at least in my mind), if there is no other good option, we can switch to color glyphs.
IMHO, Unicode is act more like another option according to the --icon-theme option.
the real problem like this issue is that we are now offering a non-functional feature --icon-theme unicode, it may not work on most OSes, that is why I think we should use a more compatible default code.
I see your point, but I am still not yet fully convinced that adding color glyphs is the best approach (Apart from changing the looks, I have seen quite a few terminal emulators having issues with rendering multi-color emojis, but I guess those will just render monochrome versions). Let me take another look into this in the coming days and we can finalize one something.
I think we will leave the unicode icons as is. The original issue was around being able to use emojis (colorful unicode icons) as icons in lsd. That I think would be covered once we have https://github.com/Peltoche/lsd/pull/707 .