lsd icon indicating copy to clipboard operation
lsd copied to clipboard

Bump crossterm to 0.28.0

Open Destroy666x opened this issue 1 year ago • 3 comments

Upgrades crossterm to fix https://github.com/lsd-rs/lsd/issues/896, https://github.com/lsd-rs/lsd/issues/607 and maybe something else


TODO

  • [ ] Use cargo fmt
  • [ ] Add necessary tests
  • [ ] Update default config/theme in README (if applicable)
  • [ ] Update man page at lsd/doc/lsd.md (if applicable)

Destroy666x avatar Oct 24 '24 07:10 Destroy666x

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Destroy666x Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

muniu-bot[bot] avatar Oct 24 '24 07:10 muniu-bot[bot]

So... what's needed here? I see the build started failing on Windows for whatever reason. Errors are unclear, so not sure if it was some temporary fail or what. It built fine for me on X64 locally when I checked, can't test i686.

Destroy666x avatar Apr 01 '25 06:04 Destroy666x

@zwpaper

Destroy666x avatar Apr 01 '25 06:04 Destroy666x