lsd
lsd copied to clipboard
Fix clap doc-comment
clap always removes the last single period from a doc-comment.
before:
~$ lsd --help
-a, --all Do not ignore entries starting with
after:
~$ lsd --help
-a, --all Do not ignore entries starting with .
TODO
- [x] Use
cargo fmt - [ ] Add necessary tests
- [ ] Update default config/theme in README (if applicable)
- [ ] Update man page at lsd/doc/lsd.md (if applicable)
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Long0x0
Once this PR has been reviewed and has the lgtm label, please assign zwpaper for approval by writing /assign @zwpaper in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
To fix this, Clap also has a flag called verbatim_doc_comment to avoid removing trailing dots and so on, but solution of this PR seems more specific (and not breaking other benefits of Clap's pre-processing).
thanks so much for this good and funny catch @outloudvi