enet icon indicating copy to clipboard operation
enet copied to clipboard

Published 20 hours ago • verified publisher icon lsalzman

CMake improvements

Open moien007 opened this issue 4 years ago • 3 comments

This is PR https://github.com/lsalzman/enet/pull/137 (which I messed up, my bad) plus new changes.

Changes are:

  • Upgrading from CMake 2.6 to 3.4.3
  • Linking against ws2_32 and winmm if compiler is MSVC
  • Conditionally defining ENET_DLL macro
  • Exporting all symbols for Win32 so that a .def file or __declspec(dllexport) is not required

moien007 avatar Dec 29 '20 11:12 moien007

@moien007 Not sure if you are still motivated since you did not get an official response, but could you perhaps rebase this? Thanks!

Croydon avatar Aug 25 '21 22:08 Croydon

@moien007 Not sure if you are still motivated since you did not get an official response, but could you perhaps rebase this? Thanks!

Solved the merge conflict; is that what you meant?

moien007 avatar Aug 26 '21 02:08 moien007

Yes, thanks.

@lsalzman Could you perhaps have a look at this patch? It isn't big so it shouldn't take long to review

Croydon avatar Aug 26 '21 03:08 Croydon