Artemis
Artemis copied to clipboard
`Development`: Move translation keys for error messages into error.json
Checklist
General
- [x] I chose a title conforming to the naming conventions for pull requests.
Client
- [x] I followed the coding and design guidelines and ensured that the layout is responsive.
- [x] I translated all newly inserted strings into English and German.
Motivation and Context
I noticed that there are two different locations in the current codebase where translations for error messages were stored. One was error.json
, the other global.json
.
Description
We should only have one general location for error messages. Therefore I moved all strings from global.json
to error.json
.
This PR additionally fixes a small bug with programming exercises and auxiliary repositories. The description was not sent to the server and therefore did not get saved.
Steps for Testing
Try to invoke some server errors and check that the resulting alert shows correct strings in both German and English.
Additionally, test the saving of descriptions for auxiliary repositories:
Create and / or edit a programming exercise:
- Add a new auxiliary repository to the exercise and set values for all fields.
- Save the exercise and check that all values got saved.
- Change the description to a long text (> 500 chars)
- Make sure that a translated error message is shown. This message should also contain the maximum length of 500 chars.
Review Progress
Code Review
- [ ] Review 1
- [ ] Review 2
Manual Tests
- [ ] Test 1
- [ ] Test 2
These words don't get translated. (But not really part of the PR)
LGTM. @Strohgelaender can you resolve the merge conflict? I would merge this today.
Ping @jpbernius