Artemis icon indicating copy to clipboard operation
Artemis copied to clipboard

`User management`: Add filter for registration number

Open dangcosta opened this issue 3 years ago • 2 comments

Checklist

General

Server

  • [x] I followed the coding and design guidelines.
  • [x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • [x] I added @PreAuthorize and checked the course groups for all new REST Calls (security).
  • [x] I implemented the changes with a good performance and prevented too many database calls.
  • [x] I documented the Java code using JavaDoc style.

Client

  • [x] I followed the coding and design guidelines and ensured that the layout is responsive.
  • [x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • [x] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • [x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • [x] I documented the TypeScript code using JSDoc style.
  • [x] I added multiple screenshots/screencasts of my UI changes.
  • [x] I translated all newly inserted strings into English and German.

Motivation and Context

This change allows the admin user to filter (besides the existing ones) by registration number and to sync the user info with the LDAP server.

Description

I added a new filter option to the filter part of the user management and a new button that allows the admin to sync with the the LDAP server.

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Log in to Artemis
  2. Navigate to User Management
  3. On the main page click on the LDAP button for users with registration number (it should be available only for the users with the LDAP profile active. It is not possible to test on the tests servers since they do not have a LDAP connection).
  4. Open the filter option and filter users with registration number, without registration number and with none filter.

Review Progress

Code Review

  • [x] Review 1
  • [x] Review 2

Manual Tests

  • [x] Test 1
  • [x] Test 2

Test Coverage

Class/File Branch Line

Screenshots

image image

dangcosta avatar Jun 22 '22 18:06 dangcosta

We should first fix the tests and finish the PR before reviewing it :+1:

Dominik-Weinzierl avatar Jul 02 '22 14:07 Dominik-Weinzierl

There are still 4 minor codacy issues, please fix them :+1:

Dominik-Weinzierl avatar Jul 30 '22 09:07 Dominik-Weinzierl