h5ai icon indicating copy to clipboard operation
h5ai copied to clipboard

Fix overhead when loading directory

Open glubsy opened this issue 4 years ago • 8 comments

  • This avoids loading content of parent directories, only adding the requested directory.
  • This drastically reduces the amount of fstat system calls, and avoid superfluous items in the response array, i.e. files from directories we don't necessarily care about.
  • This should reduce timeouts when loading directories with large numbers of files. The timeout reduction will probably fix #753, fix #629, fix #518, fix #458, fix #752.

glubsy avatar Dec 01 '20 02:12 glubsy

+1 please merge this

hartmark avatar Jan 24 '21 23:01 hartmark

That changed the average loading time for folders from 10 seconds to 30ms. That is a huge improvement.

dr2okevin avatar Oct 10 '21 09:10 dr2okevin

@lrsjng Please can you merge this!? It seems a simple fix with a lot performance boost. #ty

sommer-gei avatar Sep 13 '23 18:09 sommer-gei

This repo has been dead for a while. It seems most development has stopped when main developer stopped.

This repo seems to have most of the PRs merged https://github.com/tudorminator/h5ai

I'm not using h5ai so much any more and plus I don't have so much time to maintain a fork myself.

hartmark avatar Sep 13 '23 20:09 hartmark

This repo has been dead for a while. It seems most development has stopped when main developer stopped.

:-/ Didn't know that … Ty @hartmark for the info!

This repo seems to have most of the PRs merged https://github.com/tudorminator/h5ai

Also ty for this info, I'll look into it.

Update + FYI: I couldn't figure out the explicit Commit, but I can confirm that the patch (from this PR) is implemented (in the new repo). – So ty @glubsy + @tudorminator, too!

KR

sommer-gei avatar Sep 14 '23 09:09 sommer-gei

Side note: tudorminator's fork seems to have exactly the same commits as my fork currently.

glubsy avatar Sep 16 '23 14:09 glubsy

+1 vote for @glubsy as new benevolent dictator 😀

hartmark avatar Sep 16 '23 15:09 hartmark

Hey you two, would maybe recommend you guys to have a look at some of the newer PRs, for an example, my PR for a useBrowserLang fix #863 or this PR #855, and maybe also some of the closed once

biast12 avatar Sep 16 '23 20:09 biast12