h5ai icon indicating copy to clipboard operation
h5ai copied to clipboard

Published 20 hours ago • verified publisher icon lrsjng

Fix short videos thumbnail generation

Open glubsy opened this issue 3 years ago • 4 comments

  • Use ffprobe/avprobe to get the total duration of each video file first.
  • Compute a desired optimal timestamp of 50% of the total duration to seek for and get the thumbnail from.
  • Fix capture of ffmpeg's output (from stderr) in exec_cmdv() by using an optional redirection to stdout.
  • Capture of sub-process output is optional (possible slight performance gain).

This fixes #763, fixes #565, fixes #754, fixes #436, fixes #695.

glubsy avatar Nov 11 '20 02:11 glubsy

commit 8280aff fixes #695.

glubsy avatar Nov 29 '20 17:11 glubsy

I built your forks master branch and the webpage is just a broken page

image

You don't have issues open on your fork so I'm putting it here. Is the master branch even the correct one to use? I want all of the features you've implemented into h5ai in one package if thats possible.

Hi-ImKyle avatar Sep 06 '22 23:09 Hi-ImKyle

@Hi-ImKyle I have enabled issues just now thanks for the heads up. Yes master branch includes all my changes. No idea what your issue is, does this happen with the original version of h5ai? What server are you using? What php version? What do you see in the developer console in the web browser?

glubsy avatar Sep 07 '22 21:09 glubsy

I'll create an issue on your fork instead of polluting this one~

Hi-ImKyle avatar Sep 13 '22 11:09 Hi-ImKyle