jidoujisho icon indicating copy to clipboard operation
jidoujisho copied to clipboard

Published 20 hours ago • verified publisher icon lrorpilla

Add Chromecast support

Open facferreira opened this issue 2 years ago • 1 comments

This adds Chromecast support. It is based on an older legacy commit https://github.com/lrorpilla/jidoujisho/commit/3e7f956e8bdce9d3f6371e92c111ac395311139f.

facferreira avatar Jan 31 '22 21:01 facferreira

I've been busy with work and I haven't worked on the project for a while, and I'm super happy to see a very first pull request made,

I intend to do a pretty big refactor sometime when I'm done whiteboarding the next release and ready to make changes, I'll see if I can include these changes then

In the meantime, thank you for your interest and contribution, it means a lot to me.

lrorpilla avatar Feb 13 '22 11:02 lrorpilla

Closing this PR as it has aged since 2.0 is out, and additionally I don't have a Chromecast in the meantime to test this on. Supporting Chromecast is something that I'd like to do but given the subtitles limitations and it being a very niche want, I find it hard to position on the priority list. I might reconsider but for now I am closing the PR and won't be supporting it in the meantime unless a significant user segment really wants it.

lrorpilla avatar Sep 14 '22 21:09 lrorpilla