jidoujisho icon indicating copy to clipboard operation
jidoujisho copied to clipboard

Bug when dealing with blank sub lines in subtitles

Open damiansh opened this issue 2 years ago • 1 comments

Jidojisho version: 1.1.8 My device: Samsung Glaxy Tab S7 Plus Anime example: Detective Conan Episode 0633 Subtitle: https://drive.google.com/file/d/1_FjupqQ1vHFM5715qA2thgAm-8BsOIgS/view?usp=sharing

I am not sure how often you will find blank lines in subtitles while immersing but just in case it's something that can regularly happen I decided to post the issue.

On the show Detective Conan which I am watching now, there are some blank lines for some reason, and this apparently messes with line that goes after that blank one.

Basically, it shows the next line with its time in the timming of the blank line.

I am bad explaining so here you have an screenshot: image

After checking the sub, there is a blank line just before that one: image

The same thing happens in the next instance of a blank line: image

In the following link you have the video of the problem:

https://www.youtube.com/watch?v=bA-4VAtQazo

I have included the srt file just in case you want to take a look.

Thank you in advance, and let me know if you have any questions!f

damiansh avatar Dec 27 '21 03:12 damiansh

Changing the SRT parser might be necessary for this one, will look into the edgecases

lrorpilla avatar Jan 17 '22 10:01 lrorpilla

Closing this as 2.0 has been released.

If you can present that your issue is still present in 2.0, feel free to open.

lrorpilla avatar Sep 07 '22 09:09 lrorpilla