Laurent Rineau

CGAL_assertion(false)/CGAL_error() replace by CGAL_unreachable()?

33

There are more than 250 occurrences of `CGAL_assertion(false)` in CGAL. And other occurrences of `CGAL_error()`. Should not we replace them with `CGAL_unreachable()`?

Improvement backports from CDT_3 branch (Follow-up to PR #8170)

6

## Summary of Changes In the PR #8170, merged for CGAL-6.0, there was several commits that I had to revert, because they broke the testsuite results: - [x] commit 612d6e3f592a133a21d14a00e0ffe849b11e2b04,...

TBD -------- _Please use the following template to help us managing pull requests._ ## Summary of Changes _Describe what your pull request changes to CGAL (this can be skipped if...

> This is no problem. We use Mesh_3 as Surface Mesher. In fact even with Mesh_3 we somehow would lilke to have a function called `make_surface_mesh`. _Originally posted by @afabri...

## Issue with `Poisson_implicit_surface_3` For the moment, in `master`, we have an improved point oracle for Surface_mesher, than is only used one example file: `Poisson_surface_reconstruction_3/examples/Poisson_surface_reconstruction_3/poisson_reconstruction.cpp`. ### History _Thanks to `git...

> Note that the UBAN sanitizer does not like that code, for a null cell pointer: > > https://github.com/CGAL/cgal/blob/6547f648968441b60f7bc4733bda687b69ad3fa5/Poisson_surface_reconstruction_3/include/CGAL/Poisson_reconstruction_function.h#L261-L264 Fixed by 9cd4535b11877266e8085be3299ea81df4ed5123. Now: https://github.com/CGAL/cgal/blob/9cd4535b11877266e8085be3299ea81df4ed5123/Poisson_surface_reconstruction_3/include/CGAL/Poisson_reconstruction_function.h#L261-L267 Maybe `s_iterator_to` in the compact container...

Create a Docker installation of our internal wiki

2

The current installation can be seen at https://cgal.geometryfactory.com/CGAL/Members/wiki/Special:Version (restricted to CGAL members). The goal is to get a Docker installation of Mediawiki, with a recent version, and with the same...

https://git-scm.com/docs/gitmailmap

In: https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.0-Ic-259/Basic_viewer_Examples/TestReport_Christo_MSVC-2022-Community-Release.gz we have lines like: ``` cl /c /I"C:\CGAL_ROOT\CGAL-6.0-Ic-259\cmake\platforms\MSVC-2022-Community-Release\include" /I"C:\CGAL_ROOT\CGAL-6.0-Ic-259\include" /IC:\dev\boost_1_79_0 /I"C:\CGAL_ROOT\CGAL-6.0-Ic-259\cmake\platforms\MSVC-2022-Community-Release\test\AABB_tree_Demo" /IC:\dev\Qt6\6.6.0\msvc2019_64\include\QtWidgets /IC:\dev\Qt6\6.6.0\msvc2019_64\include /IC:\dev\Qt6\6.6.0\msvc2019_64\include\QtCore /I"C:\dev\Qt6\6.6.0\msvc2019_64\mkspecs\win32-msvc" /IC:\dev\Qt6\6.6.0\msvc2019_64\include\QtGui /IC:\dev\Qt6\6.6.0\msvc2019_64\include\QtOpenGLWidgets /IC:\dev\Qt6\6.6.0\msvc2019_64\include\QtOpenGL /IC:\dev\Qt6\6.6.0\msvc2019_64\include\QtSvg /W3 /WX- /diagnostics:column /O2 /Ob2 /D _UNICODE /D UNICODE...

create a list of third-party libraries along with the versions used on a specific platform.

1

The first step of that task is to make sure our CMake scripts display information about which third-party libraries that are available, and which versions. Then, in the testsuite scripts...