fixest icon indicating copy to clipboard operation
fixest copied to clipboard

R/etable.R: Combining character and factor in older versions of R creates NA

Open michaelquinn32 opened this issue 3 years ago • 1 comments

In earlier versions of R (say pre 4.0) this line produces a data frame of NA values: https://github.com/lrberge/fixest/blob/680972c23bef24a18840b295d129d00629dc17a4/R/etable.R#L4729

I believe that this fix is to call format() on the data frame during rbind(), which should ensure all of the values are coerced to character. But please let me know if that isn't delivering the output that you want here.

Thanks!

michaelquinn32 avatar Jun 29 '22 19:06 michaelquinn32

Thanks a lot: related to #353. One more piece of the puzzle!

lrberge avatar Sep 14 '22 20:09 lrberge

Hi, I've fixed various bugs with R 3.5.0, now it should work. Thanks for reporting.

lrberge avatar Jun 11 '24 21:06 lrberge