mackup icon indicating copy to clipboard operation
mackup copied to clipboard

Enable glob

Open semkagtn opened this issue 4 years ago • 5 comments

Some configuration files contain application version in their paths. So you have to explicitly list all the versions. For example: https://github.com/lra/mackup/blob/master/mackup/applications/intellijidea.cfg

I have add the support of globing to solve this problem. You have to explicitly enable this feature to use it. So there are no issues with backward compatibility.

Related issues: https://github.com/lra/mackup/issues/1440 https://github.com/lra/mackup/issues/1436

semkagtn avatar May 26 '20 13:05 semkagtn

@lra Is there anything preventing the merge of this PR? It really could be handy for some softwares.

nesk avatar Jan 07 '21 22:01 nesk

It's a big change with a lot of edge cases to test. If I just merge this without testing all the edge cases (ideally in unit tests), I take the risk of selling a feature that's not gonna work. Including tests would help speed this up.

lra avatar Jan 07 '21 22:01 lra

Is this dead, or has globbing been enabled elsewhere? BetterTouchTool is using versioned filenames now like:

btt_data_store.version_3_553_build_1693
btt_data_store.version_3_553_build_1693-shm
btt_data_store.version_3_553_build_1693-wal

JimJafar avatar Mar 17 '21 02:03 JimJafar

@EvilJimJafar no one has taken ownership of this yet, it's a pretty significant feature that needs solid testing before it would be published. Let us know if you want to implement this feature.

joshmedeski avatar Mar 22 '21 17:03 joshmedeski

I have forked @semkagtn's repo and added a consecutive PR https://github.com/lra/mackup/pull/1807. Please let me know what you think, e.g if more testing is needed - but let's discuss over there ;)

jneuendorf avatar Mar 14 '22 23:03 jneuendorf