Laurent Pugin

Results 399 comments of Laurent Pugin

> So, `chord@ho` and `note@ho` could cancel out each other when opposite values. Yes. (But then the note head will be disconnected from (or overlap with) the stem, so one...

### option Add the `--mensural-score-up` boolean in the `mensural` option group (false by default). Start [here](https://github.com/rism-digital/verovio/blob/248cdfdd60f46bb9ba4a42f26ba36e9aec7ba4eb/include/vrv/options.h#L837-L843) and also add it in the implementation `options.cpp` file. This should be it. Then...

@martha-thomae could you resolve the conflicts? (I would recommend not to leave the PR for too long since it might become difficult to do so)

Great, thanks. You can upload the examples to the verovio.org test suite in `_tests/mensural`. I had left a couple of comments. Could you look at these?

This has been fixed in https://github.com/rism-digital/verovio/commit/022d1a5b09795c827d9659da29de551bc0cc358a

@pe-ro moving it after the layout calculation would also be my understanding of the use of offsets. However, I can see cases where you could imagine to want it applied...

For me there is no need to rush with this. The most important point was the clarification about the use of `@ho/@vo`. I wonder if it is better to see...

We can wait for `@hdist` (and for `@vdist` too if necessary). They seem similar to `@ho` and `@vo` except for when they need to be taken into account. This is...

I would like to re-open this issue since this now starts to be a problem for Verovio. We have some contradictory interpretations for `@ho`, namely if the value should be...

Considering the discussion above, and unless there is an objection to it, I am going to prepare a PR for adding `vdist` to `att.visualOffset.vo`, and `vstartdist` and `venddist` to `att.visualOffset2.vo`.