Leon P Smith

Results 259 comments of Leon P Smith

Well the issue there is we need two forms of fallback; one for when libpq doesn't support the function, another when the backend doesn't. Or we can wait another 3-5...

Although, I would admit, if somebody got a patch into libpq that allowed us to request the textual/binary formats on a column-by-column basis, I'd be willing to require that version...

Thanks for the PR. Yes, I am aware of the build issue with travis, and haven't looked into it too deeply yet. I will not hold that against you. :)

Hmm, not seeing the commit here?

Personally, if postgresql-simple was unreleased (or very new) I probably would have made this decision in hindsight. As is, I'm a bit indifferent, but am afraid that this would cause...

Another idea, do you think we should modify the FromField instance to handle both Binary and Text?

Hmm, upon further review, I think I misunderstood this request. Maybe. Out of curiousity, can you mark an instance as deprecated and get a warning if you use it with...

Well, it is documented that the binary data is assumed to be UTF-8. More accurately it should match the character encoding for the database, but for better or worse postgresql-simple...

I agree. But since it doesn't really matter that much, I'm not inclined to "fix" it and break everybody's code. So this change would have to come: 1. At the...

Anyway, I digress. As far as supporting protocol-level parameters using libpq, I think there needs to be a way to either interpolate or use protocol-level parameters, or some combination thereof....