Language support: C#

[sor]

Hey, I really like the idea of your plugin and thought it would be nice to have for C# (Rider). Additionally you could highlight break, continue, throw and goto statements, then all of the possibly hidden control flow statements would be nicely visible.

[lppedd]

I think we should stop at return and, maybe, goto for the languages that support it.

I'd like to avoid cluttering the gutter icon space. Anyway I'll certainly look into C++ during the weekend.

Can you split the two languages in two issues?

[sor]

The solution with the gutter is only one possibility, but its the easiest for you since you already did this. I was thinking to only have a different highlighting for these control flow statements, but Rider does only have one color for all keywords. I would be fine with them being able to have a different color. The gutter would be cluttered ^^

[lppedd]

@sor So basically what I could do is

return    > gutter icon
throw     > gutter icon (new color or shape)
goto      > different foreground / background
break     > different foreground / background
continue  > different foreground / background

Is it ok? I plan on implementing return only for now, I will have more time for the other in the beginning of January.

[sor]

That's super nice, thanks! For the far future it would be nice to be able to configure to either use colors and/or an icon.

[lppedd]

@sor so do you prefer I go C# first?

[sor]

Yeah, C++ was only nice-to-have for me since I'm coding quite a lot of C# atm.

Edoardo Luppi [email protected] schrieb am Do., 19. Dez. 2019, 19:53:

@sor https://github.com/sor so do you prefer I go C# first?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lppedd/idea-return-highlighter/issues/12?email_source=notifications&email_token=AAE24BGBEWLK4RVQ4Q4CUR3QZO7LFA5CNFSM4J5K4OR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKSHDA#issuecomment-567616396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE24BFA7X7SG26GACKSCIDQZO7LFANCNFSM4J5K4ORQ .

[rodion-m]

@sor so do you prefer I go C# first?

@lppedd, Thanks in advance for C#!

[lppedd]

I was studying how to do this.
It seems there is no straightforward way, as C# is not available as a plugin.
I'll have to download Rider and check where the PSI elements are stored.