idea-conventional-commit icon indicating copy to clipboard operation
idea-conventional-commit copied to clipboard

Incompatible with version 2024.1 EAP

Open dschewchenko opened this issue 1 year ago • 5 comments

Please update =(

dschewchenko avatar Feb 08 '24 17:02 dschewchenko

@dschewchenko PR welcome ;)

I believe a new version of the plugin will be released when 2024.1 is released, maybe a tad before. IJ platform API breaking change is still possible until IJ platform stabilise their changes.

And one can build the plugin from source.

bric3 avatar Feb 26 '24 09:02 bric3

Exactly. Personally I didn't get to use 2024.1 because of a bunch of issues with Angular, so it wasn't a pressing change. I'm still stuck with 2023.3.2.

It will get released as soon as the final version is out.

lppedd avatar Feb 26 '24 10:02 lppedd

The source code is already compatible with 2024.1 btw, I just didn't test it enough.

lppedd avatar Feb 26 '24 10:02 lppedd

@lppedd By the way actions are now raising this, I believe this need to be fixed for 242. But the error report is there.

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.github.lppedd.cc.vcs.ClearLocalMessageHistoryAction' must override `getActionUpdateThread` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.github.lppedd.idea-conventional-commit]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:199)

This API was introduced in 222 I think. And it was added to control whether an action should be updated on the EDT, or if it can be performed on background. The idea is to avoid using EDT to avoid UI freeze.

One way to fix it is to write the method and lookup the enum values by reflection. Or to bump the minimum version to 222 and override these methods.

bric3 avatar Mar 01 '24 10:03 bric3

Thanks @bric3! I'll just bump the minimum version to when the enum appeared, and we should be good again!

lppedd avatar Mar 01 '24 10:03 lppedd

Please update, thank you!

lamb218 avatar Mar 15 '24 00:03 lamb218

Hi @lppedd now that the 2024.1 is out, would you mind updating the plugin. Thank you for the plugin.

prshnt avatar Apr 04 '24 11:04 prshnt

Definitely. Well be pushed to the marketplace during the weekend.

lppedd avatar Apr 04 '24 11:04 lppedd

Screenshot 2024-04-05 at 22 49 05

Running PyCharm 2024.1

Eraldo avatar Apr 05 '24 21:04 Eraldo

I've just uploaded version 0.23.0 to the Marketplace, and I suppose it will be available by tomorrow EOD.
If you can't wait for the Marketplace approval, you can grab the .zip file for manual installation here.

I'll keep the issue open until it's approved.

lppedd avatar Apr 07 '24 15:04 lppedd

I've just uploaded version 0.23.0 to the Marketplace, and I suppose it will be available by tomorrow EOD. If you can't wait for the Marketplace approval, you can grab the .zip file for manual installation here.

I'll keep the issue open until it's approved.

thanks for your work! You rock it.

Nicoss54 avatar Apr 08 '24 05:04 Nicoss54

The plugin is now available on the marketplace

mlec1 avatar Apr 08 '24 20:04 mlec1