thoas icon indicating copy to clipboard operation
thoas copied to clipboard
verified publisher icon lpil

Add property-based tests (some are failing)

Open seriyps opened this issue 3 years ago • 2 comments

Mostly based the generators on the typespecs in thoas module. Some of it borrowed from my old gist https://gist.github.com/seriyps/ffe0f5f5ba270fc4dd395208718e84d3

It fails on some input, CI would fail because of that:

  • escape => html sometimes fails
  • [{K, V}] representation of JSON objects seems to not be supported

Also I noticed typespec misses null

seriyps avatar Jan 26 '22 00:01 seriyps

Thanks for the feedback. Waiting for your answer about typespec (and null as well) and formatter.

we can merge or alternatively fix the bug then merge, depending on your preference.

I don't have any strong preference. If you are fine with red CI on master, guess might make sense to merge this PR first since it is already here. But quite unlikely that I'm going to work on the bug fix unfortunately.

seriyps avatar Jan 26 '22 18:01 seriyps

But quite unlikely that I'm going to work on the bug fix unfortunately.

Sounds like we want it merged then. The main branch doesn't deploy anywhere so a broken CI job is OK.

lpil avatar Jan 26 '22 20:01 lpil